Update IRRemoteESP8266 version to 2.5.5

factorize IR send signal function between the 2 types of receiving
Add new IRRemoteESP8266 protocols
replace pins on mega according schema
remove unecessaries spaces

lib/IRremoteESP8266/test/ir_Gree_test.cpp

@@ -1,11 +1,11 @@
 // Copyright 2017 David Conran
 
-#include "IRremoteESP8266.h"
+#include "ir_Gree.h"
 #include "IRrecv.h"
 #include "IRrecv_test.h"
+#include "IRremoteESP8266.h"
 #include "IRsend.h"
 #include "IRsend_test.h"
-#include "ir_Gree.h"
 #include "gtest/gtest.h"
 
 // Tests for sendGree().
@@ -15,8 +15,8 @@ TEST(TestSendGreeChars, SendData) {
   IRsendTest irsend(4);
   irsend.begin();
 
-  uint8_t gree_code[GREE_STATE_LENGTH] = {
-      0x12, 0x34, 0x56, 0x78, 0x90, 0xAB, 0xCD, 0xEF};
+  uint8_t gree_code[kGreeStateLength] = {0x12, 0x34, 0x56, 0x78,
+                                         0x90, 0xAB, 0xCD, 0xEF};
   irsend.reset();
   irsend.sendGree(gree_code);
   EXPECT_EQ(
@@ -31,7 +31,8 @@ TEST(TestSendGreeChars, SendData) {
       "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
       "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
       "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-      "m620s19000", irsend.outputStr());
+      "m620s19000",
+      irsend.outputStr());
 }
 
 TEST(TestSendGreeUint64, SendData) {
@@ -52,7 +53,8 @@ TEST(TestSendGreeUint64, SendData) {
       "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
       "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
       "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-      "m620s19000", irsend.outputStr());
+      "m620s19000",
+      irsend.outputStr());
 }
 
 // Test sending with repeats.
@@ -61,36 +63,37 @@ TEST(TestSendGreeChars, SendWithRepeats) {
   irsend.begin();
 
   irsend.reset();
-  uint8_t gree_code[GREE_STATE_LENGTH] = {
-      0x12, 0x34, 0x56, 0x78, 0x90, 0xAB, 0xCD, 0xEF};
+  uint8_t gree_code[kGreeStateLength] = {0x12, 0x34, 0x56, 0x78,
+                                         0x90, 0xAB, 0xCD, 0xEF};
   irsend.reset();
 
-  irsend.sendGree(gree_code, GREE_STATE_LENGTH, 1);
+  irsend.sendGree(gree_code, kGreeStateLength, 1);
   EXPECT_EQ(
-    "m9000s4000"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
-    "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
-    "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
-    "m620s540m620s1600m620s540"
-    "m620s19000"
-    "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
-    "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
-    "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
-    "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-    "m620s19000"
-    "m9000s4000"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
-    "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
-    "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
-    "m620s540m620s1600m620s540"
-    "m620s19000"
-    "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
-    "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
-    "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
-    "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-    "m620s19000", irsend.outputStr());
+      "m9000s4000"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
+      "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
+      "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
+      "m620s540m620s1600m620s540"
+      "m620s19000"
+      "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
+      "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
+      "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
+      "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
+      "m620s19000"
+      "m9000s4000"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
+      "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
+      "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
+      "m620s540m620s1600m620s540"
+      "m620s19000"
+      "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
+      "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
+      "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
+      "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
+      "m620s19000",
+      irsend.outputStr());
 }
 
 TEST(TestSendGreeUint64, SendWithRepeats) {
@@ -98,32 +101,33 @@ TEST(TestSendGreeUint64, SendWithRepeats) {
   irsend.begin();
 
   irsend.reset();
-  irsend.sendGree(0x1234567890ABCDEF, GREE_BITS, 1);
+  irsend.sendGree(0x1234567890ABCDEF, kGreeBits, 1);
   EXPECT_EQ(
-    "m9000s4000"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
-    "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
-    "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
-    "m620s540m620s1600m620s540"
-    "m620s19000"
-    "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
-    "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
-    "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
-    "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-    "m620s19000"
-    "m9000s4000"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
-    "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
-    "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
-    "m620s540m620s1600m620s540"
-    "m620s19000"
-    "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
-    "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
-    "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
-    "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-    "m620s19000", irsend.outputStr());
+      "m9000s4000"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
+      "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
+      "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
+      "m620s540m620s1600m620s540"
+      "m620s19000"
+      "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
+      "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
+      "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
+      "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
+      "m620s19000"
+      "m9000s4000"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
+      "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
+      "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
+      "m620s540m620s1600m620s540"
+      "m620s19000"
+      "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
+      "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
+      "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
+      "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
+      "m620s19000",
+      irsend.outputStr());
 }
 
 // Test sending atypical sizes.
@@ -131,30 +135,31 @@ TEST(TestSendGreeChars, SendUnexpectedSizes) {
   IRsendTest irsend(4);
   irsend.begin();
 
-  uint8_t gree_short_code[GREE_STATE_LENGTH - 1] = {
-      0x12, 0x34, 0x56, 0x78, 0x90, 0xAB, 0xCD};
-  uint8_t gree_long_code[GREE_STATE_LENGTH + 1] = {
-      0x12, 0x34, 0x56, 0x78, 0x90, 0xAB, 0xCD, 0xEF, 0x12};
+  uint8_t gree_short_code[kGreeStateLength - 1] = {0x12, 0x34, 0x56, 0x78,
+                                                   0x90, 0xAB, 0xCD};
+  uint8_t gree_long_code[kGreeStateLength + 1] = {0x12, 0x34, 0x56, 0x78, 0x90,
+                                                  0xAB, 0xCD, 0xEF, 0x12};
   irsend.reset();
-  irsend.sendGree(gree_short_code, GREE_STATE_LENGTH - 1);
+  irsend.sendGree(gree_short_code, kGreeStateLength - 1);
   ASSERT_EQ("", irsend.outputStr());
 
   irsend.reset();
-  irsend.sendGree(gree_long_code, GREE_STATE_LENGTH + 1);
+  irsend.sendGree(gree_long_code, kGreeStateLength + 1);
   ASSERT_EQ(
-    "m9000s4000"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
-    "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
-    "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
-    "m620s540m620s1600m620s540"
-    "m620s19000"
-    "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
-    "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
-    "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
-    "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
-    "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
-    "m620s19000", irsend.outputStr());
+      "m9000s4000"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s540m620s540m620s1600m620s540m620s1600m620s1600m620s540m620s540"
+      "m620s540m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540"
+      "m620s540m620s540m620s540m620s1600m620s1600m620s1600m620s1600m620s540"
+      "m620s540m620s1600m620s540"
+      "m620s19000"
+      "m620s540m620s540m620s540m620s540m620s1600m620s540m620s540m620s1600"
+      "m620s1600m620s1600m620s540m620s1600m620s540m620s1600m620s540m620s1600"
+      "m620s1600m620s540m620s1600m620s1600m620s540m620s540m620s1600m620s1600"
+      "m620s1600m620s1600m620s1600m620s1600m620s540m620s1600m620s1600m620s1600"
+      "m620s540m620s1600m620s540m620s540m620s1600m620s540m620s540m620s540"
+      "m620s19000",
+      irsend.outputStr());
 }
 
 TEST(TestSendGreeUint64, SendUnexpectedSizes) {
@@ -162,11 +167,11 @@ TEST(TestSendGreeUint64, SendUnexpectedSizes) {
   irsend.begin();
 
   irsend.reset();
-  irsend.sendGree(0x1234567890ABCDEF, GREE_BITS - 1);
+  irsend.sendGree(0x1234567890ABCDEF, kGreeBits - 1);
   ASSERT_EQ("", irsend.outputStr());
 
   irsend.reset();
-  irsend.sendGree(0x1234567890ABCDEF, GREE_BITS + 1);
+  irsend.sendGree(0x1234567890ABCDEF, kGreeBits + 1);
   ASSERT_EQ("", irsend.outputStr());
 }
 
@@ -174,8 +179,8 @@ TEST(TestSendGree, CompareUint64ToCharResults) {
   IRsendTest irsend_chars(4);
   IRsendTest irsend_uint64(0);
 
-  uint8_t gree_code[GREE_STATE_LENGTH] = {
-      0x12, 0x34, 0x56, 0x78, 0x90, 0xAB, 0xCD, 0xEF};
+  uint8_t gree_code[kGreeStateLength] = {0x12, 0x34, 0x56, 0x78,
+                                         0x90, 0xAB, 0xCD, 0xEF};
 
   irsend_chars.begin();
   irsend_uint64.begin();
@@ -186,12 +191,12 @@ TEST(TestSendGree, CompareUint64ToCharResults) {
   irsend_uint64.sendGree(0x1234567890ABCDEF);
   ASSERT_EQ(irsend_chars.outputStr(), irsend_uint64.outputStr());
 
-  uint8_t gree_zero_code[GREE_STATE_LENGTH] = {
-      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
+  uint8_t gree_zero_code[kGreeStateLength] = {0x00, 0x00, 0x00, 0x00,
+                                              0x00, 0x00, 0x00, 0x00};
   irsend_chars.reset();
   irsend_uint64.reset();
   irsend_chars.sendGree(gree_zero_code);
-  irsend_uint64.sendGree((uint64_t) 0x0);
+  irsend_uint64.sendGree((uint64_t)0x0);
   ASSERT_EQ(irsend_chars.outputStr(), irsend_uint64.outputStr());
 }
 
@@ -218,25 +223,25 @@ TEST(TestGreeClass, Temperature) {
   IRGreeAC irgree(0);
   irgree.begin();
 
-  irgree.setMode(GREE_COOL);
+  irgree.setMode(kGreeCool);
 
   irgree.setTemp(0);
-  EXPECT_EQ(GREE_MIN_TEMP, irgree.getTemp());
+  EXPECT_EQ(kGreeMinTemp, irgree.getTemp());
 
   irgree.setTemp(255);
-  EXPECT_EQ(GREE_MAX_TEMP, irgree.getTemp());
+  EXPECT_EQ(kGreeMaxTemp, irgree.getTemp());
 
-  irgree.setTemp(GREE_MIN_TEMP);
-  EXPECT_EQ(GREE_MIN_TEMP, irgree.getTemp());
+  irgree.setTemp(kGreeMinTemp);
+  EXPECT_EQ(kGreeMinTemp, irgree.getTemp());
 
-  irgree.setTemp(GREE_MAX_TEMP);
-  EXPECT_EQ(GREE_MAX_TEMP, irgree.getTemp());
+  irgree.setTemp(kGreeMaxTemp);
+  EXPECT_EQ(kGreeMaxTemp, irgree.getTemp());
 
-  irgree.setTemp(GREE_MIN_TEMP - 1);
-  EXPECT_EQ(GREE_MIN_TEMP, irgree.getTemp());
+  irgree.setTemp(kGreeMinTemp - 1);
+  EXPECT_EQ(kGreeMinTemp, irgree.getTemp());
 
-  irgree.setTemp(GREE_MAX_TEMP + 1);
-  EXPECT_EQ(GREE_MAX_TEMP, irgree.getTemp());
+  irgree.setTemp(kGreeMaxTemp + 1);
+  EXPECT_EQ(kGreeMaxTemp, irgree.getTemp());
 
   irgree.setTemp(17);
   EXPECT_EQ(17, irgree.getTemp());
@@ -256,34 +261,34 @@ TEST(TestGreeClass, OperatingMode) {
   irgree.begin();
 
   irgree.setTemp(17);
-  irgree.setMode(GREE_AUTO);  // Auto should lock the temp to 25C.
-  EXPECT_EQ(GREE_AUTO, irgree.getMode());
+  irgree.setMode(kGreeAuto);  // Auto should lock the temp to 25C.
+  EXPECT_EQ(kGreeAuto, irgree.getMode());
   EXPECT_EQ(25, irgree.getTemp());
   irgree.setTemp(17);
   EXPECT_EQ(25, irgree.getTemp());
 
-  irgree.setMode(GREE_COOL);
-  EXPECT_EQ(GREE_COOL, irgree.getMode());
+  irgree.setMode(kGreeCool);
+  EXPECT_EQ(kGreeCool, irgree.getMode());
 
-  irgree.setMode(GREE_HEAT);
-  EXPECT_EQ(GREE_HEAT, irgree.getMode());
+  irgree.setMode(kGreeHeat);
+  EXPECT_EQ(kGreeHeat, irgree.getMode());
 
-  ASSERT_NE(GREE_FAN_MAX, 1);
-  irgree.setFan(GREE_FAN_MAX);
-  irgree.setMode(GREE_DRY);  // Dry should lock the fan to speed 1.
-  EXPECT_EQ(GREE_DRY, irgree.getMode());
+  ASSERT_NE(kGreeFanMax, 1);
+  irgree.setFan(kGreeFanMax);
+  irgree.setMode(kGreeDry);  // Dry should lock the fan to speed 1.
+  EXPECT_EQ(kGreeDry, irgree.getMode());
   EXPECT_EQ(1, irgree.getFan());
-  irgree.setFan(GREE_FAN_MAX);
+  irgree.setFan(kGreeFanMax);
   EXPECT_EQ(1, irgree.getFan());
 
-  irgree.setMode(GREE_FAN);
-  EXPECT_EQ(GREE_FAN, irgree.getMode());
+  irgree.setMode(kGreeFan);
+  EXPECT_EQ(kGreeFan, irgree.getMode());
 
-  irgree.setMode(GREE_HEAT + 1);
-  EXPECT_EQ(GREE_AUTO, irgree.getMode());
+  irgree.setMode(kGreeHeat + 1);
+  EXPECT_EQ(kGreeAuto, irgree.getMode());
 
   irgree.setMode(255);
-  EXPECT_EQ(GREE_AUTO, irgree.getMode());
+  EXPECT_EQ(kGreeAuto, irgree.getMode());
 }
 
 TEST(TestGreeClass, Light) {
@@ -350,16 +355,16 @@ TEST(TestGreeClass, FanSpeed) {
   EXPECT_EQ(0, irgree.getFan());
 
   irgree.setFan(255);
-  EXPECT_EQ(GREE_FAN_MAX, irgree.getFan());
+  EXPECT_EQ(kGreeFanMax, irgree.getFan());
 
-  irgree.setFan(GREE_FAN_MAX);
-  EXPECT_EQ(GREE_FAN_MAX, irgree.getFan());
+  irgree.setFan(kGreeFanMax);
+  EXPECT_EQ(kGreeFanMax, irgree.getFan());
 
-  irgree.setFan(GREE_FAN_MAX + 1);
-  EXPECT_EQ(GREE_FAN_MAX, irgree.getFan());
+  irgree.setFan(kGreeFanMax + 1);
+  EXPECT_EQ(kGreeFanMax, irgree.getFan());
 
-  irgree.setFan(GREE_FAN_MAX - 1);
-  EXPECT_EQ(GREE_FAN_MAX - 1, irgree.getFan());
+  irgree.setFan(kGreeFanMax - 1);
+  EXPECT_EQ(kGreeFanMax - 1, irgree.getFan());
 
   irgree.setFan(1);
   EXPECT_EQ(1, irgree.getFan());
@@ -375,48 +380,48 @@ TEST(TestGreeClass, VerticalSwing) {
   IRGreeAC irgree(0);
   irgree.begin();
   EXPECT_FALSE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_LAST_POS, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingLastPos, irgree.getSwingVerticalPosition());
 
-  irgree.setSwingVertical(true, GREE_SWING_AUTO);
+  irgree.setSwingVertical(true, kGreeSwingAuto);
   EXPECT_TRUE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_AUTO, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingAuto, irgree.getSwingVerticalPosition());
 
-  irgree.setSwingVertical(false, GREE_SWING_MIDDLE);
+  irgree.setSwingVertical(false, kGreeSwingMiddle);
   EXPECT_FALSE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_MIDDLE, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingMiddle, irgree.getSwingVerticalPosition());
 
-  irgree.setSwingVertical(true, GREE_SWING_DOWN_AUTO);
+  irgree.setSwingVertical(true, kGreeSwingDownAuto);
   EXPECT_TRUE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_DOWN_AUTO, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingDownAuto, irgree.getSwingVerticalPosition());
 
   // Out of bounds.
   irgree.setSwingVertical(false, 255);
   EXPECT_FALSE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_LAST_POS, irgree.getSwingVerticalPosition());
-  irgree.setSwingVertical(false, GREE_SWING_AUTO);
+  EXPECT_EQ(kGreeSwingLastPos, irgree.getSwingVerticalPosition());
+  irgree.setSwingVertical(false, kGreeSwingAuto);
   EXPECT_FALSE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_LAST_POS, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingLastPos, irgree.getSwingVerticalPosition());
 
   irgree.setSwingVertical(true, 255);
   EXPECT_TRUE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_AUTO, irgree.getSwingVerticalPosition());
-  irgree.setSwingVertical(true, GREE_SWING_DOWN);
+  EXPECT_EQ(kGreeSwingAuto, irgree.getSwingVerticalPosition());
+  irgree.setSwingVertical(true, kGreeSwingDown);
   EXPECT_TRUE(irgree.getSwingVerticalAuto());
-  EXPECT_EQ(GREE_SWING_AUTO, irgree.getSwingVerticalPosition());
+  EXPECT_EQ(kGreeSwingAuto, irgree.getSwingVerticalPosition());
 }
 
 TEST(TestGreeClass, SetAndGetRaw) {
   IRGreeAC irgree(0);
-  uint8_t initialState[GREE_STATE_LENGTH] = {
-      0x00, 0x09, 0x20, 0x50, 0x00, 0x20, 0x00, 0x50};
-  uint8_t expectedState[GREE_STATE_LENGTH] = {
-      0xA9, 0x05, 0xD0, 0x50, 0x00, 0x20, 0x00, 0xA0};
+  uint8_t initialState[kGreeStateLength] = {0x00, 0x09, 0x20, 0x50,
+                                            0x00, 0x20, 0x00, 0x50};
+  uint8_t expectedState[kGreeStateLength] = {0xA9, 0x05, 0xD0, 0x50,
+                                             0x00, 0x20, 0x00, 0xA0};
 
-  EXPECT_STATE_EQ(initialState, irgree.getRaw(), GREE_BITS);
+  EXPECT_STATE_EQ(initialState, irgree.getRaw(), kGreeBits);
 
   // toggle the power state.
   irgree.setPower(!irgree.getPower());
-  irgree.setMode(GREE_COOL);
+  irgree.setMode(kGreeCool);
   irgree.setTemp(21);
   irgree.setFan(2);
   irgree.setLight(false);
@@ -424,7 +429,7 @@ TEST(TestGreeClass, SetAndGetRaw) {
   irgree.setSleep(true);
   irgree.setXFan(true);
 
-  EXPECT_EQ(GREE_COOL, irgree.getMode());
+  EXPECT_EQ(kGreeCool, irgree.getMode());
   EXPECT_EQ(21, irgree.getTemp());
   EXPECT_EQ(2, irgree.getFan());
   EXPECT_FALSE(irgree.getLight());
@@ -432,31 +437,33 @@ TEST(TestGreeClass, SetAndGetRaw) {
   EXPECT_TRUE(irgree.getSleep());
   EXPECT_TRUE(irgree.getXFan());
 
-  EXPECT_STATE_EQ(expectedState, irgree.getRaw(), GREE_BITS);
+  EXPECT_STATE_EQ(expectedState, irgree.getRaw(), kGreeBits);
   irgree.setRaw(initialState);
-  EXPECT_STATE_EQ(initialState, irgree.getRaw(), GREE_BITS);
+  EXPECT_STATE_EQ(initialState, irgree.getRaw(), kGreeBits);
 }
 
 TEST(TestGreeClass, HumanReadable) {
   IRGreeAC irgree(0);
 
-  EXPECT_EQ("Power: Off, Mode: 0 (AUTO), Temp: 25C, Fan: 0 (AUTO), Turbo: Off, "
-            "XFan: Off, Light: On, Sleep: Off, Swing Vertical Mode: Manual, "
-            "Swing Vertical Pos: 0 (Last Pos)",
-            irgree.toString());
+  EXPECT_EQ(
+      "Power: Off, Mode: 0 (AUTO), Temp: 25C, Fan: 0 (AUTO), Turbo: Off, "
+      "XFan: Off, Light: On, Sleep: Off, Swing Vertical Mode: Manual, "
+      "Swing Vertical Pos: 0 (Last Pos)",
+      irgree.toString());
   irgree.on();
-  irgree.setMode(GREE_COOL);
-  irgree.setTemp(GREE_MIN_TEMP);
-  irgree.setFan(GREE_FAN_MAX);
+  irgree.setMode(kGreeCool);
+  irgree.setTemp(kGreeMinTemp);
+  irgree.setFan(kGreeFanMax);
   irgree.setXFan(true);
   irgree.setSleep(true);
   irgree.setLight(false);
   irgree.setTurbo(true);
-  irgree.setSwingVertical(true, GREE_SWING_AUTO);
-  EXPECT_EQ("Power: On, Mode: 1 (COOL), Temp: 16C, Fan: 3 (MAX), Turbo: On, "
-            "XFan: On, Light: Off, Sleep: On, Swing Vertical Mode: Auto, "
-            "Swing Vertical Pos: 1 (Auto)",
-            irgree.toString());
+  irgree.setSwingVertical(true, kGreeSwingAuto);
+  EXPECT_EQ(
+      "Power: On, Mode: 1 (COOL), Temp: 16C, Fan: 3 (MAX), Turbo: On, "
+      "XFan: On, Light: Off, Sleep: On, Swing Vertical Mode: Auto, "
+      "Swing Vertical Pos: 1 (Auto)",
+      irgree.toString());
 }
 
 // Tests for decodeGree().
@@ -467,16 +474,16 @@ TEST(TestDecodeGree, NormalSynthetic) {
   IRrecv irrecv(4);
   irsend.begin();
 
-  uint8_t gree_code[GREE_STATE_LENGTH] = {
-      0x00, 0x09, 0x20, 0x50, 0x00, 0x20, 0x00, 0x50};
+  uint8_t gree_code[kGreeStateLength] = {0x00, 0x09, 0x20, 0x50,
+                                         0x00, 0x20, 0x00, 0x50};
 
   irsend.reset();
   irsend.sendGree(gree_code);
   irsend.makeDecodeResult();
   EXPECT_TRUE(irrecv.decode(&irsend.capture));
   EXPECT_EQ(GREE, irsend.capture.decode_type);
-  ASSERT_EQ(GREE_BITS, irsend.capture.bits);
-  EXPECT_STATE_EQ(gree_code, irsend.capture.state, GREE_BITS);
+  ASSERT_EQ(kGreeBits, irsend.capture.bits);
+  EXPECT_STATE_EQ(gree_code, irsend.capture.state, kGreeBits);
 }
 
 // Decode a synthetic Gree message.
@@ -486,31 +493,35 @@ TEST(TestDecodeGree, NormalRealExample) {
   IRGreeAC irgree(4);
   irsend.begin();
 
-  uint8_t gree_code[GREE_STATE_LENGTH] = {
-      0x19, 0x0A, 0x60, 0x50, 0x02, 0x23, 0x00, 0xF0};
+  uint8_t gree_code[kGreeStateLength] = {0x19, 0x0A, 0x60, 0x50,
+                                         0x02, 0x23, 0x00, 0xF0};
 
   // Ref: https://github.com/markszabo/IRremoteESP8266/issues/386
   uint16_t rawData[139] = {
-      9008, 4496, 644, 1660, 676, 530, 648, 558, 672, 1636, 646, 1660, 644, 556,
-      650, 584, 626, 560, 644, 580, 628, 1680, 624, 560, 648, 1662, 644, 582,
-      648, 536, 674, 530, 646, 580, 628, 560, 670, 532, 646, 562, 644, 556, 672,
-      536, 648, 1662, 646, 1660, 652, 554, 644, 558, 672, 538, 644, 560, 668,
-      560, 648, 1638, 668, 536, 644, 1660, 668, 532, 648, 560, 648, 1660, 674,
-      554, 622, 19990, 646, 580, 624, 1660, 648, 556, 648, 558, 674, 556, 622,
-      560, 644, 564, 668, 536, 646, 1662, 646, 1658, 672, 534, 648, 558, 644,
-      562, 648, 1662, 644, 584, 622, 558, 648, 562, 668, 534, 670, 536, 670,
-      532, 672, 536, 646, 560, 646, 558, 648, 558, 670, 534, 650, 558, 646, 560,
-      646, 560, 668, 1638, 646, 1662, 646, 1660, 646, 1660, 648};  // Issue #386
+      9008, 4496,  644, 1660, 676, 530,  648, 558,  672, 1636, 646, 1660,
+      644,  556,   650, 584,  626, 560,  644, 580,  628, 1680, 624, 560,
+      648,  1662,  644, 582,  648, 536,  674, 530,  646, 580,  628, 560,
+      670,  532,   646, 562,  644, 556,  672, 536,  648, 1662, 646, 1660,
+      652,  554,   644, 558,  672, 538,  644, 560,  668, 560,  648, 1638,
+      668,  536,   644, 1660, 668, 532,  648, 560,  648, 1660, 674, 554,
+      622,  19990, 646, 580,  624, 1660, 648, 556,  648, 558,  674, 556,
+      622,  560,   644, 564,  668, 536,  646, 1662, 646, 1658, 672, 534,
+      648,  558,   644, 562,  648, 1662, 644, 584,  622, 558,  648, 562,
+      668,  534,   670, 536,  670, 532,  672, 536,  646, 560,  646, 558,
+      648,  558,   670, 534,  650, 558,  646, 560,  646, 560,  668, 1638,
+      646,  1662,  646, 1660, 646, 1660, 648};  // Issue #386
 
   irsend.reset();
   irsend.sendRaw(rawData, 139, 38000);
   irsend.makeDecodeResult();
   EXPECT_TRUE(irrecv.decode(&irsend.capture));
   EXPECT_EQ(GREE, irsend.capture.decode_type);
-  ASSERT_EQ(GREE_BITS, irsend.capture.bits);
-  EXPECT_STATE_EQ(gree_code, irsend.capture.state, GREE_BITS);
+  ASSERT_EQ(kGreeBits, irsend.capture.bits);
+  EXPECT_STATE_EQ(gree_code, irsend.capture.state, kGreeBits);
   irgree.setRaw(irsend.capture.state);
-  EXPECT_EQ("Power: On, Mode: 1 (COOL), Temp: 26C, Fan: 1, Turbo: Off, "
-            "XFan: Off, Light: On, Sleep: Off, Swing Vertical Mode: Manual, "
-            "Swing Vertical Pos: 2", irgree.toString());
+  EXPECT_EQ(
+      "Power: On, Mode: 1 (COOL), Temp: 26C, Fan: 1, Turbo: Off, "
+      "XFan: Off, Light: On, Sleep: Off, Swing Vertical Mode: Manual, "
+      "Swing Vertical Pos: 2",
+      irgree.toString());
 }