Fix unit discovery for kg and kpa (#1171)

And improve the code
This commit is contained in:
Florian authored and GitHub committed 2022-02-25 05:51:59 -06:00
1 parent 8a75e85b60
commit e6c8b6763c
2 files changed
+10 -13

No files matched your search

+9 -12
View File
@@ -245,38 +245,35 @@ void createDiscovery(const char* sensor_type,
sensor["stat_t"] = state_topic; sensor["stat_t"] = state_topic;
} }
// We check if the class belongs to HAAS class list if (device_class[0]) {
bool HASSClass = false; // We check if the class belongs to HAAS classes list
int num_classes = sizeof(availableHASSClasses) / sizeof(availableHASSClasses[0]); int num_classes = sizeof(availableHASSClasses) / sizeof(availableHASSClasses[0]);
for (int i = 0; i < num_classes; i++) { // see class list and size into config_mqttDiscovery.h for (int i = 0; i < num_classes; i++) { // see class list and size into config_mqttDiscovery.h
if (strcmp(availableHASSClasses[i], device_class) == 0) { if (strcmp(availableHASSClasses[i], device_class) == 0) {
HASSClass = true; sensor["dev_cla"] = device_class; //device_class
}
} }
} }
// We check if the class belongs to HAAS class list if (unit_of_meas[0]) {
bool HASSUnit = false; // We check if the class belongs to HAAS units list
int num_units = sizeof(availableHASSUnits) / sizeof(availableHASSUnits[0]); int num_units = sizeof(availableHASSUnits) / sizeof(availableHASSUnits[0]);
for (int i = 0; i < num_units; i++) { // see class list and size into config_mqttDiscovery.h for (int i = 0; i < num_units; i++) { // see units list and size into config_mqttDiscovery.h
if (strcmp(availableHASSUnits[i], unit_of_meas) == 0) { if (strcmp(availableHASSUnits[i], unit_of_meas) == 0) {
HASSUnit = true; sensor["unit_of_meas"] = unit_of_meas; //unit_of_measurement*/
}
} }
} }
sensor["name"] = s_name; //name sensor["name"] = s_name; //name
sensor["uniq_id"] = unique_id; //unique_id sensor["uniq_id"] = unique_id; //unique_id
if (retainCmd) if (retainCmd)
sensor["retain"] = retainCmd; // Retain command sensor["retain"] = retainCmd; // Retain command
if (device_class[0] && HASSClass)
sensor["dev_cla"] = device_class; //device_class
if (value_template[0]) if (value_template[0])
sensor["val_tpl"] = value_template; //value_template sensor["val_tpl"] = value_template; //value_template
if (payload_on[0]) if (payload_on[0])
sensor["pl_on"] = payload_on; // payload_on sensor["pl_on"] = payload_on; // payload_on
if (payload_off[0]) if (payload_off[0])
sensor["pl_off"] = payload_off; //payload_off sensor["pl_off"] = payload_off; //payload_off
if (unit_of_meas[0] && HASSUnit)
sensor["unit_of_meas"] = unit_of_meas; //unit_of_measurement*/
if (off_delay != 0) if (off_delay != 0)
sensor["off_delay"] = off_delay; //off_delay sensor["off_delay"] = off_delay; //off_delay
if (payload_available[0]) if (payload_available[0])
+1 -1
View File
@@ -227,7 +227,7 @@ const char* availableHASSUnits[] = {"W",
"°F", "°F",
"ms", "ms",
"s", "s",
"hPa" "hPa",
"kg", "kg",
"lb", "lb",
"µS/cm", "µS/cm",