From b01240330aa158b4f499fcf59e47a18c34701fea Mon Sep 17 00:00:00 2001 From: Florian Date: Tue, 30 Jun 2026 06:09:04 -0500 Subject: [PATCH] [ONOFF] Fix ACTUATOR_TRIGGER build flag: missing -D prefix (#2334) Several envs pass '-ACTUATOR_TRIGGER=true' instead of '-DACTUATOR_TRIGGER=true', so the ACTUATOR_TRIGGER macro is never defined and the physical-button -> relay toggle in sensorGPIOInput.cpp (#if defined(ZactuatorONOFF) && defined(ACTUATOR_TRIGGER)) is compiled out. Verified on a Theengs Plug: with the -D added, a button press now toggles the relay and emits ONOFFtoMQTT. Same one-character fix applied to the other envs carrying the identical typo. Affected envs: theengs-plug, esp32dev-all-test, sonoff-basic, sonoff-basic-rfr3. Co-authored-by: Claude Opus 4.8 (1M context) --- environments.ini | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/environments.ini b/environments.ini index 3c3a72d..845cbbf 100644 --- a/environments.ini +++ b/environments.ini @@ -161,7 +161,7 @@ build_flags = '-DACTUATOR_ON=1' '-DACTUATOR_OFF=0' '-DACTUATOR_BUTTON_TRIGGER_LEVEL=0' - '-ACTUATOR_TRIGGER=true' + '-DACTUATOR_TRIGGER=true' '-DZsensorGPIOInput="GPIOInput"' '-DINPUT_GPIO=4' '-DACTUATOR_ONOFF_GPIO=25' @@ -231,7 +231,7 @@ build_flags = '-DZgatewayBT="BT"' '-DZactuatorONOFF="ONOFF"' '-DACTUATOR_BUTTON_TRIGGER_LEVEL=0' - '-ACTUATOR_TRIGGER=true' + '-DACTUATOR_TRIGGER=true' '-DZactuatorFASTLED="FASTLED"' '-DZactuatorPWM="PWM"' '-DZsensorINA226="INA226"' @@ -1761,7 +1761,7 @@ build_flags = '-DACTUATOR_ON=0' '-DACTUATOR_ONOFF_DEFAULT=ACTUATOR_ON' '-DACTUATOR_BUTTON_TRIGGER_LEVEL=0' - '-ACTUATOR_TRIGGER=true' + '-DACTUATOR_TRIGGER=true' '-DGateway_Name="OMG_SONOFF_RELAY"' board_build.flash_mode = dout custom_description = Basic Sonoff wifi relay @@ -1784,7 +1784,7 @@ build_flags = '-DACTUATOR_ON=0' '-DACTUATOR_ONOFF_DEFAULT=ACTUATOR_ON' '-DACTUATOR_BUTTON_TRIGGER_LEVEL=0' - '-ACTUATOR_TRIGGER=true' + '-DACTUATOR_TRIGGER=true' '-DRF_RECEIVER_GPIO=4' '-DZgatewayRF="RF"' '-DGateway_Name="OMG_SONOFF_BASIC_RFR3"'