[SYS] Introduce MQTT Broker mode (#1988)

.github/workflows/build.yml

@@ -79,6 +79,7 @@ jobs:
           - "theengs-bridge"
           - "esp32dev-ble-idf"
           - "theengs-bridge-v11"
+          - "esp32dev-ble-broker"
     runs-on: ubuntu-latest
     name: Build with PlatformIO
     steps:

environments.ini

@@ -338,6 +338,24 @@ build_flags =
   '-DGateway_Name="OMG_ESP32_BLE"'
 custom_description = Regular BLE gateway with adaptive scanning activated, automatically adapts the scan parameters depending on your devices
 
+[env:esp32dev-ble-broker]
+platform = ${com.esp32_platform}
+board = esp32dev
+extra_scripts = ${com-esp32.extra_scripts}
+board_build.partitions = min_spiffs.csv
+lib_deps =
+  ${com-esp32.lib_deps}
+  ${libraries.ble}
+  ${libraries.decoder}
+build_flags =
+  ${com-esp32.build_flags}
+  '-DZgatewayBT="BT"'
+  '-DLED_SEND_RECEIVE=2'
+  '-DLED_SEND_RECEIVE_ON=0'
+  '-DGateway_Name="OMG_ESP32_BLE"'
+  '-DMQTT_BROKER_MODE=true'
+custom_description = MQTT Broker with BLE gateway with adaptive scanning activated, automatically adapts the scan parameters depending on your devices
+
 [env:esp32dev-ble-mqtt-undecoded]
 platform = ${com.esp32_platform}
 board = esp32dev

main/User_config.h

@@ -212,6 +212,15 @@
 #  define AWS_IOT false
 #endif
 
+#ifndef MQTT_BROKER_MODE
+#  define MQTT_BROKER_MODE false
+#endif
+
+#if MQTT_BROKER_MODE
+// In MQTT broker mode the MQTT web config is not needed
+#  define WIFIMNG_HIDE_MQTT_CONFIG true
+#endif
+
 #define GITHUB_OTA_SERVER_CERT_HASH "d4d211b4553af9fac371f24c2268d59d2b0fec6b9aa0fdbbde068f078d7daf86" // SHA256 fingerprint of the certificate used by the OTA server
 
 #if AWS_IOT
@@ -264,6 +273,7 @@ const char* OTAserver_cert = "";
 
 #include <string>
 
+#if !MQTT_BROKER_MODE
 struct ss_cnt_parameters {
   std::string server_cert;
   std::string client_cert;
@@ -279,14 +289,15 @@ struct ss_cnt_parameters {
 };
 
 // Index 0 is used for connection parameters provided in the build that can be overloaded by WiFi Manager/Onboarding/WebUI,MQTT
-#define CNT_DEFAULT_INDEX 0
+#  define CNT_DEFAULT_INDEX 0
 // Index 1 and more are used for connection parameters provided at runtime by MQTT
-#define cnt_parameters_array_size 3
+#  define cnt_parameters_array_size 3
 
 ss_cnt_parameters cnt_parameters_array[cnt_parameters_array_size] = {
     {ss_server_cert, ss_client_cert, ss_client_key, OTAserver_cert, MQTT_SERVER, MQTT_PORT, MQTT_USER, MQTT_PASS, MQTT_SECURE_DEFAULT, MQTT_CERT_VALIDATE_DEFAULT, false},
     {"", "", "", "", MQTT_SERVER, MQTT_PORT, MQTT_USER, MQTT_PASS, MQTT_SECURE_DEFAULT, MQTT_CERT_VALIDATE_DEFAULT, false},
     {"", "", "", "", MQTT_SERVER, MQTT_PORT, MQTT_USER, MQTT_PASS, MQTT_SECURE_DEFAULT, MQTT_CERT_VALIDATE_DEFAULT, false}};
+#endif
 
 #define MIN_CERT_LENGTH 200 // Minimum length of a certificate to be considered valid
 

main/Zblufi.ino

@@ -145,6 +145,7 @@ static void example_event_callback(esp_blufi_cb_event_t event, esp_blufi_cb_para
       }
       if (!json.isNull()) {
         Log.trace(F("\nparsed json, size: %u" CR), json.memoryUsage());
+#  if !MQTT_BROKER_MODE
         if (json.containsKey("mqtt_server") && json["mqtt_server"].is<const char*>() && json["mqtt_server"].as<String>().length() > 0 && json["mqtt_server"].as<String>().length() < parameters_size)
           strcpy(cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_server, json["mqtt_server"]);
         if (json.containsKey("mqtt_port") && json["mqtt_port"].is<const char*>() && json["mqtt_port"].as<String>().length() > 0 && json["mqtt_port"].as<String>().length() < parameters_size)
@@ -166,12 +167,6 @@ static void example_event_callback(esp_blufi_cb_event_t event, esp_blufi_cb_para
           cnt_parameters_array[CNT_DEFAULT_INDEX].client_key = json["mqtt_client_key"].as<const char*>();
         if (json.containsKey("ota_server_cert") && json["ota_server_cert"].is<const char*>() && json["ota_server_cert"].as<String>().length() > MIN_CERT_LENGTH)
           cnt_parameters_array[CNT_DEFAULT_INDEX].ota_server_cert = json["ota_server_cert"].as<const char*>();
-        if (json.containsKey("gateway_name"))
-          strcpy(gateway_name, json["gateway_name"]);
-        if (json.containsKey("mqtt_topic"))
-          strcpy(mqtt_topic, json["mqtt_topic"]);
-        if (json.containsKey("ota_pass"))
-          strcpy(ota_pass, json["ota_pass"]);
 
         if (json.containsKey("cnt_index") && json["cnt_index"].is<int>() && json["cnt_index"].as<int>() > 0 && json["cnt_index"].as<int>() < 3) {
           cnt_index = json["cnt_index"].as<int>();
@@ -181,6 +176,14 @@ static void example_event_callback(esp_blufi_cb_event_t event, esp_blufi_cb_para
 
         // We suppose the connection is valid (could be tested before)
         cnt_parameters_array[cnt_index].validConnection = true;
+#  endif
+
+        if (json.containsKey("gateway_name"))
+          strcpy(gateway_name, json["gateway_name"]);
+        if (json.containsKey("mqtt_topic"))
+          strcpy(mqtt_topic, json["mqtt_topic"]);
+        if (json.containsKey("ota_pass"))
+          strcpy(ota_pass, json["ota_pass"]);
 
         saveConfig();
       }

main/ZgatewayBT.ino

@@ -807,7 +807,7 @@ void coreTask(void* pvParameters) {
         n++;
         delay(1000);
       }
-      if (!connected) {
+      if (!mqtt->connected()) {
         Log.warning(F("MQTT client or Network disconnected no BLE scan" CR));
       } else if (!BTProcessLock) {
         if (xSemaphoreTake(semaphoreBLEOperation, pdMS_TO_TICKS(30000)) == pdTRUE) {

main/ZwebUI.ino

@@ -706,6 +706,7 @@ void handleMQ() {
       JsonObject WEBtoSYS = WEBtoSYSBuffer.to<JsonObject>();
       bool update = false;
 
+#  if !MQTT_BROKER_MODE
       if (server.hasArg("mh")) {
         WEBtoSYS["mqtt_server"] = server.arg("mh");
         if (strncmp(cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_server, server.arg("mh").c_str(), parameters_size)) {
@@ -746,6 +747,7 @@ void handleMQ() {
           WEBtoSYS.remove(it);
         }
       }
+#  endif
 
       if (server.hasArg("h")) {
         WEBtoSYS["gateway_name"] = server.arg("h");
@@ -802,7 +804,11 @@ void handleMQ() {
   response += String(script);
   response += String(style);
   // mqtt server (mh), mqtt port (ml), mqtt username (mu), mqtt password (mp), secure connection (sc), server certificate (msc), topic (mt)
+#  if MQTT_BROKER_MODE
+  snprintf(buffer, WEB_TEMPLATE_BUFFER_MAX_SIZE, config_mqtt_body, jsonChar, gateway_name, "", "1883", "", "", gateway_name, mqtt_topic);
+#  else
   snprintf(buffer, WEB_TEMPLATE_BUFFER_MAX_SIZE, config_mqtt_body, jsonChar, gateway_name, cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_server, cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_port, cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_user, (cnt_parameters_array[CNT_DEFAULT_INDEX].isConnectionSecure ? "checked" : ""), gateway_name, mqtt_topic);
+#  endif
   response += String(buffer);
   snprintf(buffer, WEB_TEMPLATE_BUFFER_MAX_SIZE, footer, OMG_VERSION);
   response += String(buffer);

main/main.ino

@@ -231,8 +231,6 @@ char ota_pass[parameters_size] = gw_password;
 char WifiManager_ssid[MAC_NAME_MAX_LEN];
 char ota_hostname[MAC_NAME_MAX_LEN];
 #endif
-bool connectedOnce = false; //indicate if we have been connected once to MQTT
-bool connected = false; //indicate whether we are currently connected. Used to detected re-connection
 int failure_number_ntwk = 0; // number of failure connecting to network
 int failure_number_mqtt = 0; // number of failure connecting to MQTT
 
@@ -299,8 +297,60 @@ ESP8266WiFiMulti wifiMulti;
 #  include <Ethernet.h>
 #endif
 
-std::unique_ptr<::Client> eClient;
+void handle_autodiscovery() {
+#ifdef ZmqttDiscovery
+  static bool connectedOnce = false;
+  const unsigned long now = millis();
+
+  // at first connection we publish the discovery payloads
+  // or, when we have just re-connected (only when discovery_republish_on_reconnect is enabled)
+  const bool publishDiscovery = SYSConfig.discovery && (!connectedOnce || discovery_republish_on_reconnect);
+
+  if (publishDiscovery) {
+    pubMqttDiscovery();
+#  ifdef ZgatewayLORA
+    launchLORADiscovery(true);
+#  endif
+#  ifdef ZgatewayBT
+    launchBTDiscovery(true);
+#  endif
+#  ifdef ZgatewayRTL_433
+    launchRTL_433Discovery(true);
+#  endif
+  }
+
+  connectedOnce = true;
+#endif
+}
+
+#if MQTT_BROKER_MODE
+
+class MQTTServer : public PicoMQTT::Server {
+public:
+  size_t get_client_count() const {
+    return clients.size();
+  }
+
+  bool connected() const {
+    return !clients.empty();
+  }
+
+protected:
+  virtual void on_subscribe(const char* client_id, const char* topic) override {
+    // Whenever a client subscribes successfully to some topic, see if this is likely a subscription to a
+    // autodiscovery topic.  If it is, fire handle_autodiscovery().
+    const String pattern(topic);
+    const bool is_autodiscovery_subscription = (pattern == "#") || (pattern.startsWith(String(discovery_Topic) + "/"));
+    if (is_autodiscovery_subscription)
+      handle_autodiscovery();
+  }
+};
+
+std::unique_ptr<MQTTServer> mqtt;
+#else
+std::unique_ptr< ::Client> eClient;
 std::unique_ptr<PicoMQTT::Client> mqtt;
+#endif
 
 template <typename T> // Declared here to avoid pre-compilation issue (missing "template" in auto declaration by pio)
 void Config_update(JsonObject& data, const char* key, T& var);
@@ -660,7 +710,7 @@ void pubMQTT(const char* topic, const char* payload) {
  */
 void pubMQTT(const char* topic, const char* payload, bool retainFlag) {
   if (SYSConfig.XtoMQTT) {
-    if (mqtt->connected()) {
+    if (mqtt && mqtt->connected()) {
       SendReceiveIndicatorON();
       Log.trace(F("[ OMG->MQTT ] topic: %s msg: %s " CR), topic, payload);
       mqtt->publish(topic, payload, 0, retainFlag);
@@ -870,6 +920,15 @@ std::pair<String, uint16_t> discoverMQTTbroker() {
 }
 #endif
 
+#if MQTT_BROKER_MODE
+void setupMQTT() {
+  Log.notice(F("Reconfiguring MQTT broker..." CR));
+
+  mqtt.reset(new MQTTServer());
+  mqtt->begin();
+}
+#else
+
 struct ss_cnt_parameters_backup {
   ss_cnt_parameters parameters;
   int cnt_index;
@@ -900,15 +959,15 @@ void setupMQTT() {
     eClient.reset(new WiFiClient);
   }
 
-#if defined(MDNS_SD)
+#  if defined(MDNS_SD)
   Log.trace(F("Connecting to MQTT by mDNS without MQTT hostname" CR));
   const auto discovered_broker = discoverMQTTbroker();
   const auto broker_host = discovered_broker.first.c_str();
   const auto broker_port = discovered_broker.second;
-#else
+#  else
   const auto broker_host = parameters.mqtt_server;
   const auto broker_port = String(parameters.mqtt_port).toInt();
-#endif
+#  endif
 
   Log.trace(F("Mqtt server: %s" CR), broker_host);
   Log.trace(F("Port: %u" CR), broker_port);
@@ -920,21 +979,21 @@ void setupMQTT() {
                                   (GeneralTimeOut - 1) * 1000 // socket timeout [ms]
                                   ));
 
-#if AWS_IOT
+#  if AWS_IOT
   // AWS doesn't support will topic for the moment
   mqtt->will.topic = "";
   mqtt->will.payload = "";
   mqtt->will.qos = 0;
   mqtt->will.retain = false;
-#else
+#  else
   mqtt->will.topic = String(mqtt_topic) + gateway_name + will_Topic;
   mqtt->will.payload = will_Message;
   mqtt->will.qos = will_QoS;
   mqtt->will.retain = will_Retain;
-#endif
+#  endif
 
   mqtt->connected_callback = [] {
-#if AWS_IOT
+#  if AWS_IOT
     {
       // Define a threshold for instability detection
       constexpr unsigned int reconnection_threshold = 5;
@@ -958,7 +1017,7 @@ void setupMQTT() {
         SYSConfig.XtoMQTT = false;
       }
     }
-#endif
+#  endif
 
     displayPrint("MQTT connected");
     Log.notice(F("Connected to broker" CR));
@@ -972,14 +1031,16 @@ void setupMQTT() {
       cnt_parameters_array[cnt_index].validConnection = true;
       readCntParameters(cnt_index);
 
-#ifndef ESPWifiManualSetup
+#  ifndef ESPWifiManualSetup
       if (cnt_parameters_backup->saveOnSuccess) // Save the new parameters to the flash
         saveConfig();
-#endif
+#  endif
 
       cnt_parameters_backup.reset();
       ESPRestart(7);
     }
+
+    handle_autodiscovery();
   };
 
   mqtt->connection_failure_callback = [] {
@@ -994,11 +1055,11 @@ void setupMQTT() {
 
     if (parameters.isConnectionSecure) {
       WiFiClientSecure* client = static_cast<WiFiClientSecure*>(eClient.get());
-#if defined(ESP32)
+#  if defined(ESP32)
       Log.warning(F("failed, ssl error code=%d" CR), client->lastError(nullptr, 0));
-#elif defined(ESP8266)
+#  elif defined(ESP8266)
       Log.warning(F("failed, ssl error code=%d" CR), client->getLastSSLError());
-#endif
+#  endif
     }
 
     if (cnt_parameters_backup) {
@@ -1018,7 +1079,7 @@ void setupMQTT() {
     delayWithOTA(5000);
 
     if (failure_number_mqtt > maxRetryWatchDog) {
-#ifndef ESPWifiManualSetup
+#  ifndef ESPWifiManualSetup
       // Look for the next valid connection
       for (int i = 0; i < cnt_parameters_array_size; i++) {
         cnt_index++;
@@ -1033,7 +1094,7 @@ void setupMQTT() {
           Log.notice(F("Connection %d not valid" CR), cnt_index);
         }
       }
-#endif
+#  endif
       unsigned long millis_since_last_ota;
       while (
           // When
@@ -1053,18 +1114,19 @@ void setupMQTT() {
 
   mqtt->subscribe(String(mqtt_topic) + gateway_name + subjectMQTTtoX, receivingMQTT, mqtt_max_payload_size);
 
-#ifdef ZgatewayRF
+#  ifdef ZgatewayRF
   // subject on which other OMG will publish, this OMG will store these msg and by the way don't republish them if they have been already published
   mqtt->subscribe(subjectMultiGTWRF, receivingMQTT, mqtt_max_payload_size);
-#endif
+#  endif
 
-#ifdef ZgatewayIR
+#  ifdef ZgatewayIR
   // subject on which other OMG will publish, this OMG will store these msg and by the way don't republish them if they have been already published
   mqtt->subscribe(subjectMultiGTWIR, receivingMQTT, mqtt_max_payload_size);
-#endif
+#  endif
 
   mqtt->begin();
 }
+#endif
 
 #if defined(ESP32) && (defined(WifiGMode) || defined(WifiPower))
 void setESPWifiProtocolTxPower() {
@@ -1269,13 +1331,15 @@ void setup() {
   Log.trace(F("OpenMQTTGateway mac: %s" CR), WiFi.macAddress().c_str());
   Log.trace(F("OpenMQTTGateway ip: %s" CR), WiFi.localIP().toString().c_str());
   Log.trace(F("OpenMQTTGateway index %d" CR), cnt_index);
+  Log.trace(F("OpenMQTTGateway mqtt topic: %s" CR), mqtt_topic);
+  Log.trace(F("OpenMQTTGateway gateway name: %s" CR), gateway_name);
+#if !MQTT_BROKER_MODE
   Log.trace(F("OpenMQTTGateway mqtt server: %s" CR), cnt_parameters_array[cnt_index].mqtt_server);
   Log.trace(F("OpenMQTTGateway mqtt port: %s" CR), cnt_parameters_array[cnt_index].mqtt_port);
   Log.trace(F("OpenMQTTGateway mqtt user: %s" CR), cnt_parameters_array[cnt_index].mqtt_user);
-  Log.trace(F("OpenMQTTGateway mqtt topic: %s" CR), mqtt_topic);
-  Log.trace(F("OpenMQTTGateway gateway name: %s" CR), gateway_name);
   Log.trace(F("OpenMQTTGateway secure connection: %s" CR), cnt_parameters_array[cnt_index].isConnectionSecure ? "true" : "false");
   Log.trace(F("OpenMQTTGateway validate cert: %s" CR), cnt_parameters_array[cnt_index].isCertValidate ? "true" : "false");
+#endif
 
   setOTA();
 
@@ -1538,6 +1602,7 @@ void setOTA() {
   ArduinoOTA.begin();
 }
 
+#if !MQTT_BROKER_MODE
 void setupTLS(int index) {
   configTime(0, 0, NTP_SERVER);
   WiFiClientSecure* sClient = static_cast<WiFiClientSecure*>(eClient.get());
@@ -1547,7 +1612,7 @@ void setupTLS(int index) {
     sClient->setInsecure();
   } else {
     Log.notice(F("Enabling cert validation" CR));
-#if defined(ESP32)
+#  if defined(ESP32)
     if (cnt_parameters_array[index].server_cert.length() > MIN_CERT_LENGTH) {
       sClient->setCACert(cnt_parameters_array[index].server_cert.c_str());
       Log.notice(F("Server cert found from cert array" CR));
@@ -1584,7 +1649,7 @@ void setupTLS(int index) {
       Log.error(F("No client key found" CR));
     }
 #    endif
-#elif defined(ESP8266)
+#  elif defined(ESP8266)
     caCert.append(cnt_parameters_array[index].server_cert.c_str());
     sClient->setTrustAnchors(&caCert);
     sClient->setBufferSizes(512, 512);
@@ -1599,9 +1664,10 @@ void setupTLS(int index) {
     pClKey = new PrivateKey(cnt_parameters_array[index].client_key.c_str());
     sClient->setClientRSACert(pClCert, pClKey);
 #    endif
-#endif
+#  endif
   }
 }
+#endif
 
 /*
   Reboot for Reason Codes
@@ -1768,8 +1834,9 @@ void checkButton() {}
 
 void saveConfig() {
   Log.trace(F("saving configs" CR));
-  int totalSize = 512;
 
+  int totalSize = 512;
+#  if !MQTT_BROKER_MODE
   for (int i = 0; i < 3; ++i) { // index 0 contains the default values from the build, these values can't be changed at runtime
     if (cnt_parameters_array[i].validConnection) {
       totalSize += cnt_parameters_array[i].server_cert.length();
@@ -1778,10 +1845,13 @@ void saveConfig() {
       totalSize += cnt_parameters_array[i].ota_server_cert.length();
     }
   }
+#  endif
 
   Log.notice(F("Total size: %d" CR), totalSize);
 
   DynamicJsonDocument json(512 + totalSize);
+
+#  if !MQTT_BROKER_MODE
   for (int i = 0; i < 3; ++i) {
     if (cnt_parameters_array[i].validConnection) {
       char index_suffix[2];
@@ -1839,6 +1909,7 @@ void saveConfig() {
   if (cnt_parameters_array[cnt_index].validConnection) {
     json["cnt_index"] = cnt_index;
   }
+#  endif
 
   json["mqtt_topic"] = mqtt_topic;
   json["gateway_name"] = gateway_name;
@@ -1881,6 +1952,7 @@ bool loadConfigFromFlash() {
         // Print json to serial port
         //serializeJsonPretty(json, Serial);
 
+#  if !MQTT_BROKER_MODE
         for (int i = 0; i < 3; ++i) {
           char index_suffix[2]; // Large enough for 0, 1, or 2 and the null terminator
           if (i == 0) {
@@ -1965,6 +2037,7 @@ bool loadConfigFromFlash() {
         if (json.containsKey("cnt_index")) {
           cnt_index = json["cnt_index"].as<int>();
         }
+#  endif
         if (json.containsKey("mqtt_topic"))
           strcpy(mqtt_topic, json["mqtt_topic"]);
         if (json.containsKey("gateway_name"))
@@ -2023,13 +2096,11 @@ void setupwifi(bool reset_settings) {
   // After connecting, parameter.getValue() will get you the configured value
   // id/name placeholder/prompt default
 #  ifndef WIFIMNG_HIDE_MQTT_CONFIG
+#    if !MQTT_BROKER_MODE
   WiFiManagerParameter custom_mqtt_server("server", "mqtt server", cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_server, parameters_size, " minlength='1' maxlength='64' required");
   WiFiManagerParameter custom_mqtt_port("port", "mqtt port", cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_port, 6, " minlength='1' maxlength='5' required");
   WiFiManagerParameter custom_mqtt_user("user", "mqtt user", cnt_parameters_array[CNT_DEFAULT_INDEX].mqtt_user, parameters_size, " maxlength='64'");
   WiFiManagerParameter custom_mqtt_pass("pass", "mqtt pass", MQTT_PASS, parameters_size, " input type='password' maxlength='64'");
-  WiFiManagerParameter custom_mqtt_topic("topic", "mqtt base topic", mqtt_topic, mqtt_topic_max_size, " minlength='1' maxlength='64' required");
-  WiFiManagerParameter custom_gateway_name("name", "gateway name", gateway_name, parameters_size, " minlength='1' maxlength='64' required");
-  WiFiManagerParameter custom_ota_pass("ota", "gateway password", ota_pass, parameters_size, " input type='password' minlength='8' maxlength='64' required");
   WiFiManagerParameter custom_mqtt_secure("secure", "<br/>mqtt secure", "1", 2, cnt_parameters_array[CNT_DEFAULT_INDEX].isConnectionSecure ? "type=\"checkbox\" checked" : "type=\"checkbox\"");
   WiFiManagerParameter custom_validate_cert("validate", "<br/>validate cert", "1", 2, cnt_parameters_array[CNT_DEFAULT_INDEX].isCertValidate ? "type=\"checkbox\" checked" : "type=\"checkbox\"");
   WiFiManagerParameter custom_mqtt_cert("cert", "<br/>mqtt server cert", "", 4096);
@@ -2038,6 +2109,10 @@ void setupwifi(bool reset_settings) {
   WiFiManagerParameter custom_client_cert("client_cert", "<br/>mqtt client cert", "", 4096);
   WiFiManagerParameter custom_client_key("client_key", "<br/>mqtt client key", "", 4096);
 #      endif
+#    endif
+  WiFiManagerParameter custom_mqtt_topic("topic", "mqtt base topic", mqtt_topic, mqtt_topic_max_size, " minlength='1' maxlength='64' required");
+  WiFiManagerParameter custom_gateway_name("name", "gateway name", gateway_name, parameters_size, " minlength='1' maxlength='64' required");
+  WiFiManagerParameter custom_ota_pass("ota", "gateway password", ota_pass, parameters_size, " input type='password' minlength='8' maxlength='64' required");
 #  endif
   //WiFiManager
   //Local intialization. Once its business is done, there is no need to keep it around
@@ -2065,21 +2140,23 @@ void setupwifi(bool reset_settings) {
 
 #  ifndef WIFIMNG_HIDE_MQTT_CONFIG
   //add all your parameters here
+#    if !MQTT_BROKER_MODE
   wifiManager.addParameter(&custom_mqtt_server);
   wifiManager.addParameter(&custom_mqtt_port);
   wifiManager.addParameter(&custom_mqtt_user);
   wifiManager.addParameter(&custom_mqtt_pass);
-  wifiManager.addParameter(&custom_gateway_name);
-  wifiManager.addParameter(&custom_mqtt_topic);
-  wifiManager.addParameter(&custom_ota_pass);
-  wifiManager.addParameter(&custom_ota_server_cert);
   wifiManager.addParameter(&custom_mqtt_secure);
-  wifiManager.addParameter(&custom_validate_cert);
   wifiManager.addParameter(&custom_mqtt_cert);
+  wifiManager.addParameter(&custom_validate_cert);
+  wifiManager.addParameter(&custom_ota_server_cert);
 #      if MQTT_SECURE_SIGNED_CLIENT
   wifiManager.addParameter(&custom_client_cert);
   wifiManager.addParameter(&custom_client_key);
 #      endif
+#    endif
+  wifiManager.addParameter(&custom_gateway_name);
+  wifiManager.addParameter(&custom_mqtt_topic);
+  wifiManager.addParameter(&custom_ota_pass);
 #  endif
   //set minimum quality of signal so it ignores AP's under that quality
   wifiManager.setMinimumSignalQuality(MinimumWifiSignalQuality);
@@ -2152,6 +2229,7 @@ void setupwifi(bool reset_settings) {
     //read updated parameters
     cnt_index = CNT_DEFAULT_INDEX;
 #  ifndef WIFIMNG_HIDE_MQTT_CONFIG
+#    if !MQTT_BROKER_MODE
     strcpy(cnt_parameters_array[cnt_index].mqtt_server, custom_mqtt_server.getValue());
     strcpy(cnt_parameters_array[cnt_index].mqtt_port, custom_mqtt_port.getValue());
     strcpy(cnt_parameters_array[cnt_index].mqtt_user, custom_mqtt_user.getValue());
@@ -2165,8 +2243,6 @@ void setupwifi(bool reset_settings) {
       strcat(mqtt_topic, "/");
     }
 
-    strcpy(gateway_name, custom_gateway_name.getValue());
-    strcpy(ota_pass, custom_ota_pass.getValue());
     cnt_parameters_array[cnt_index].isConnectionSecure = *custom_mqtt_secure.getValue();
     cnt_parameters_array[cnt_index].isCertValidate = *custom_validate_cert.getValue();
     if (strlen(custom_mqtt_cert.getValue()) > MIN_CERT_LENGTH) {
@@ -2184,8 +2260,14 @@ void setupwifi(bool reset_settings) {
     }
 #      endif
 #    endif
+    strcpy(gateway_name, custom_gateway_name.getValue());
+    strcpy(ota_pass, custom_ota_pass.getValue());
+#  endif
+
+#  if !MQTT_BROKER_MODE
     // We suppose the connection is valid (could be tested before)
     cnt_parameters_array[cnt_index].validConnection = true;
+#  endif
 
     //save the custom parameters to FS
     saveConfig();
@@ -2293,22 +2375,14 @@ void loop() {
     if (mqtt->connected()) { // MQTT client is still connected
       InfoIndicatorON();
       failure_number_ntwk = 0;
-      // We have just re-connected if connected was previously false
+
-      const bool justReconnected = !connected;
 #ifdef ZmqttDiscovery
       // Deactivate autodiscovery after DiscoveryAutoOffTimer.
       // Exception: when discovery_republish_on_reconnect is enabled, we never never automatically disable discovery
       if (!discovery_republish_on_reconnect && SYSConfig.discovery && (now > lastDiscovery + DiscoveryAutoOffTimer))
         SYSConfig.discovery = false;
-      // at first connection we publish the discovery payloads
-      // or, when we have just re-connected (only when discovery_republish_on_reconnect is enabled)
-      bool publishDiscovery = SYSConfig.discovery && (!connectedOnce || (discovery_republish_on_reconnect && justReconnected));
-      if (publishDiscovery) {
-        pubMqttDiscovery();
-      }
 #endif
-      connectedOnce = true;
+
-      connected = true;
       if (now > (timer_sys_measures + (TimeBetweenReadingSYS * 1000)) || !timer_sys_measures) {
         timer_sys_measures = millis();
         stateMeasures();
@@ -2408,7 +2482,7 @@ void loop() {
       LORAtoMQTT();
 #  ifdef ZmqttDiscovery
       if (SYSConfig.discovery)
-        launchLORADiscovery(publishDiscovery);
+        launchLORADiscovery(false);
 #  endif
 #endif
 #ifdef ZgatewayRF
@@ -2429,7 +2503,7 @@ void loop() {
 #ifdef ZgatewayBT
 #  ifdef ZmqttDiscovery
       if (SYSConfig.discovery)
-        launchBTDiscovery(publishDiscovery);
+        launchBTDiscovery(false);
 #  endif
 #endif
 #ifdef ZgatewaySRFB
@@ -2459,19 +2533,14 @@ void loop() {
       RTL_433Loop();
 #  ifdef ZmqttDiscovery
       if (SYSConfig.discovery)
-        launchRTL_433Discovery(publishDiscovery);
+        launchRTL_433Discovery(false);
 #  endif
 #endif
-
-    } else {
-      // MQTT disconnected
-      connected = false;
     }
   } else { // disconnected from network
 #ifdef ESP32
     //esp_task_wdt_reset();
 #endif
-    connected = false;
     Log.warning(F("Network disconnected" CR));
     ErrorIndicatorON();
     delay(2000); // add a delay to avoid ESP32 crash and reset
@@ -2621,9 +2690,11 @@ String stateMeasures() {
   }
 #endif
   SYSdata["freemem"] = freeMem;
+#if !MQTT_BROKER_MODE
   SYSdata["mqttp"] = cnt_parameters_array[cnt_index].mqtt_port;
   SYSdata["mqtts"] = cnt_parameters_array[cnt_index].isConnectionSecure;
   SYSdata["mqttv"] = cnt_parameters_array[cnt_index].isCertValidate;
+#endif
   SYSdata["msgprc"] = queueLengthSum;
   SYSdata["msgblck"] = blockedMessages;
   SYSdata["maxq"] = maxQueueLength;
@@ -2893,10 +2964,13 @@ bool checkForUpdates() {
   http.setFollowRedirects(HTTPC_STRICT_FOLLOW_REDIRECTS);
 
   std::string ota_cert;
+#      if !MQTT_BROKER_MODE
   if (cnt_parameters_array[cnt_index].ota_server_cert.length() > MIN_CERT_LENGTH) {
     Log.notice(F("Using memory cert" CR));
     ota_cert = cnt_parameters_array[cnt_index].ota_server_cert;
-  } else {
+  } else
+#      endif
+  {
     Log.notice(F("Using config cert" CR));
     ota_cert = OTAserver_cert;
   }
@@ -3006,10 +3080,13 @@ void MQTTHttpsFWUpdate(char* topicOri, JsonObject& HttpsFwUpdateData) {
       std::string ota_cert = processCert(HttpsFwUpdateData["ota_server_cert"] | "");
       Log.notice(F("OTA cert: %s" CR), ota_cert.c_str());
       if (ota_cert.length() < MIN_CERT_LENGTH && !strstr(url, "http:")) {
+#  if !MQTT_BROKER_MODE
         if (cnt_parameters_array[cnt_index].ota_server_cert.length() > MIN_CERT_LENGTH) {
           Log.notice(F("Using memory cert" CR));
           ota_cert = cnt_parameters_array[cnt_index].ota_server_cert.c_str();
-        } else {
+        } else
+#  endif
+        {
           Log.notice(F("Using config cert" CR));
           ota_cert = OTAserver_cert;
         }
@@ -3029,11 +3106,14 @@ void MQTTHttpsFWUpdate(char* topicOri, JsonObject& HttpsFwUpdateData) {
 
       } else {
         WiFiClientSecure update_client;
+#  if !MQTT_BROKER_MODE
         if (cnt_parameters_array[cnt_index].isConnectionSecure) {
           mqtt.reset();
           mqttSetupPending = true;
           update_client = *static_cast<WiFiClientSecure*>(eClient.get());
-        } else {
+        } else
+#  endif
+        {
           syncNTP();
         }
 
@@ -3072,8 +3152,10 @@ void MQTTHttpsFWUpdate(char* topicOri, JsonObject& HttpsFwUpdateData) {
           jsondata["installed_version"] = latestVersion;
           jsondata["origin"] = subjectRLStoMQTT;
           handleJsonEnqueue(jsondata);
+#  if !MQTT_BROKER_MODE
           if (cnt_index != 0) // We don't enable the change of cert provided at build time
             cnt_parameters_array[cnt_index].ota_server_cert = ota_cert;
+#  endif
 #  ifndef ESPWifiManualSetup
           saveConfig();
 #  endif
@@ -3090,6 +3172,7 @@ void MQTTHttpsFWUpdate(char* topicOri, JsonObject& HttpsFwUpdateData) {
 }
 #endif
 
+#if !MQTT_BROKER_MODE
 /**
  * Read the certificates from the memory and publish a hash of the cert to the broker for identification purposes
 */
@@ -3123,6 +3206,7 @@ void readCntParameters(int index) {
 
   pub(subjectSYStoMQTT, jsondata);
 }
+#endif
 
 void MQTTtoSYS(char* topicOri, JsonObject& SYSdata) { // json object decoding
   if (cmpToMainTopic(topicOri, subjectMQTTtoSYSset)) {
@@ -3213,7 +3297,8 @@ void MQTTtoSYS(char* topicOri, JsonObject& SYSdata) { // json object decoding
       mqttSetupPending = true; // trigger reconnect in loop using the new topic/name
     }
 
-#ifdef MQTTsetMQTT
+#if !MQTT_BROKER_MODE
+#  ifdef MQTTsetMQTT
 
     bool save_cnt = false;
     bool read_cnt = false;
@@ -3310,6 +3395,7 @@ void MQTTtoSYS(char* topicOri, JsonObject& SYSdata) { // json object decoding
       // no request to test or save the parameters, forget the old settings
       cnt_parameters_backup.reset();
     }
+#  endif
 #endif
 
     if (SYSdata.containsKey("xtomqtt") && SYSdata["xtomqtt"].is<bool>()) {