chriz/OpenMQTT-Gateway
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Correct the bit lengths of various IR protocols

Browse Source 
Disable Panasonic codes as it is called wrong.
Store data in an unsigned variable, vs a signed on, otherwise it produces bad results for high numbered codes.
Mark protocols that are > 32 bits as they won't work with values large than an unsigned long (32 bits).
This commit is contained in:
crankyoldgit authored and GitHub committed 2017-01-06 13:03:01 +10:00
1 parent 2cd6862c2c
commit 5775f3fe63
1 file changed
+12 -9
Download Patch File Download Diff File Expand all files Collapse all files
_433nIRtoMQTTto433nIR_ESP8266.ino
+12 -9
View File
@@ -251,7 +251,7 @@ void receivingMQTT(String topicNameRec, String callbackstring) {
client.publish("home/ack", DataAck); client.publish("home/ack", DataAck);
callbackstring.toCharArray(datacallback,26); callbackstring.toCharArray(datacallback,26);
trc(datacallback); trc(datacallback);
long int data = atol(datacallback); unsigned long data = atol(datacallback);
trc(String(data)); trc(String(data));
if (topicNameRec == subjectMQTTto433){ if (topicNameRec == subjectMQTTto433){
@@ -261,23 +261,26 @@ void receivingMQTT(String topicNameRec, String callbackstring) {
} }
//send received MQTT value by IR signal (example of signal sent data = 1086296175) //send received MQTT value by IR signal (example of signal sent data = 1086296175)
if (topicNameRec == subjectMQTTtoIRCOOLIX) if (topicNameRec == subjectMQTTtoIRCOOLIX)
irsend.sendCOOLIX(data, 36); irsend.sendCOOLIX(data, 36); // Note: data (unsigned long) is only 32bits long on the ESP8266.
if (topicNameRec == subjectMQTTtoIRWhynter) if (topicNameRec == subjectMQTTtoIRWhynter)
irsend.sendWhynter(data, 36); irsend.sendWhynter(data, 32);
if (topicNameRec == subjectMQTTtoIRNEC) if (topicNameRec == subjectMQTTtoIRNEC)
irsend.sendNEC(data, 36); irsend.sendNEC(data, 32);
if (topicNameRec == subjectMQTTtoIRLG) if (topicNameRec == subjectMQTTtoIRLG)
irsend.sendLG(data, 36); irsend.sendLG(data, 28);
if (topicNameRec == subjectMQTTtoIRSony) if (topicNameRec == subjectMQTTtoIRSony)
irsend.sendSony(data, 36); irsend.sendSony(data, 12);
if (topicNameRec == subjectMQTTtoIRDISH) if (topicNameRec == subjectMQTTtoIRDISH)
irsend.sendDISH(data, 36); irsend.sendDISH(data, 36); // Note: data (unsigned long) is only 32bits long on the ESP8266.
if (topicNameRec == subjectMQTTtoIRSharp) if (topicNameRec == subjectMQTTtoIRSharp)
irsend.sendSharp(data, 36); irsend.sendSharp(data, 36); // Note: data (unsigned long) is only 32bits long on the ESP8266.
/*
Panasonic has a two arguments per call. An address(16bit) and data(32bit), not data and nr_bits.
if (topicNameRec == subjectMQTTtoIRPanasonic) if (topicNameRec == subjectMQTTtoIRPanasonic)
irsend.sendPanasonic(data, 36); irsend.sendPanasonic(data, 36);
*/
if (topicNameRec == subjectMQTTtoIRSAMSUNG) if (topicNameRec == subjectMQTTtoIRSAMSUNG)
irsend.sendSAMSUNG(data, 36); irsend.sendSAMSUNG(data, 32);
} }
//send MQTT data dataStr to topic topicNameSend //send MQTT data dataStr to topic topicNameSend